Make private repo label accessible #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woo! Doesn't look like too much of an extreme change in context too:
|
👍 LGTM |
|
Awesome! Going to get it in a release soon. Thanks. |
|
Thanks @jonrohan ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important that all users are able to read a website with ease be it when being viewed by someone having colour deficits or when viewed on a black and white screen.
We should be aiming for all colours to be at least AA compliant.
Private repo label
The private repo label doesn't pass colour contrast 😢
After - uses flash warn text colour http://primercss.io/alerts/#variations
@sophshep as you bought this up ❤️
@mdo @jonrohan